Skip to content

Documentations: Ecosystem/API - pydatastream (issue #5630) #9195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2015

Conversation

vfilimonov
Copy link
Contributor

Following an old issue #5630 (Documentation / Remote Data Access - 3rd pary libraries).

Quandl was already described in Ecosystem / API section, so I've added link to pydatastream that targets Thomson Reuters Datastream.

closes #5630.

@@ -130,6 +130,13 @@ API
Quandl API for Python wraps the Quandl REST API to return
Pandas DataFrames with timeseries indexes.

`pydatastream <https://github.com/vfilimonov/pydatastream>`_
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this line at least as long as the title above it? (otherwise sphinx raises warnings ..)

@jorisvandenbossche jorisvandenbossche added this to the 0.16.0 milestone Jan 5, 2015
@jorisvandenbossche
Copy link
Member

Does this close #5630 fully?

@vfilimonov
Copy link
Contributor Author

@jorisvandenbossche - OK, fixed

@vfilimonov
Copy link
Contributor Author

I think it fully closes #5630.

As a second thought, I'm not sure if it makes sense to add support to Quandl/python or pydatastream directly in web.DataReader. It will amount to

import quandl
return Quandl.get(...)

or

from pydatastream import Datastream
DWE = Datastream(username="...", password="...")
return DWE.fetch(...)

What do you think?

@jorisvandenbossche
Copy link
Member

I also think including this in pandas is not needed. First you raise the point of the non-free data source. And if the packages have a nice interface to get these data as you show above, they can certainly be a package on their own. We are also thinking of rather moving some of the data readers included in pandas to separate packages, rather than including more of them (see #8961). It is very easy to install eg the quandl package.

Then, for this PR: we always ask to squash the commits into one commit (you can do this with git rebase -i upstream/master) for small changes. Can you do this?
If problems, just ask, or I can also do it on merge.

@vfilimonov
Copy link
Contributor Author

Just to be sure: after rebase I'm getting another branch (as the first one was already pushed to github).
Do I need to submit another PR from the new branch?

@jorisvandenbossche
Copy link
Member

Normally, the command I gave does rebase your existing branch (doc_ecosystem_api), so you can just push it again to your fork, and this PR will automatically be updated (you will only have to 'force push': git push --force origin doc_ecosystem_api

@vfilimonov
Copy link
Contributor Author

Aha, force push! Thanks, I did not know about it

Done then

@jorisvandenbossche
Copy link
Member

OK, thanks!

jorisvandenbossche added a commit that referenced this pull request Jan 6, 2015
Documentations: Ecosystem/API - pydatastream (issue #5630)
@jorisvandenbossche jorisvandenbossche merged commit 128ce85 into pandas-dev:master Jan 6, 2015
@jorisvandenbossche
Copy link
Member

And if you are interested more in general in the data readers, certainly chime in on the linked issue #8961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation / Remote Data Access - 3rd pary libraries
2 participants